Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the documentation #227

Merged
merged 4 commits into from
Nov 3, 2018
Merged

Fixing the documentation #227

merged 4 commits into from
Nov 3, 2018

Conversation

duvivier
Copy link
Contributor

@duvivier duvivier commented Nov 3, 2018

Fixing documentation so that buildthedocs can build documentation properly.

  • Developer(s): Alice DuVivier

  • Please suggest code Pull Request reviewers in the column at right.

  • Are the code changes bit for bit, different at roundoff level, or more substantial? b4b

  • Please include the link to test results or paste the summary block from the bottom of the testing output below.

  • Does this PR create or have dependencies on Icepack or any other models? N

  • Is the documentation being updated with this PR? (Y/N) Y
    If not, does the documentation need to be updated separately at a later time? (Y/N) N

Note: "Documentation" includes information on the wiki and .rst files in doc/source/,
which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.

  • Other Relevant Details:
    It looks like there were two problems.
    (1) The original missing comma after part of one of the entries. I fixed that in an earlier PR.
    (2) The "example templates" I had put into the master_list.bib seemed to crash the builds. This issue The second seems to be only with the online readthedocs build and does not manifest itself with a sphinx build on my laptop. I have no idea why there is the discrepancy with the two build methods, but I have tested this PR with my laptop sphinx AND my readthedocs account. See link below for "pass" builds:
    https://readthedocs.org/projects/cice/builds/
    To fix this I've put the example template in a separate text file so that the formatting and notes are preserved but not causing failing builds.

@duvivier duvivier self-assigned this Nov 3, 2018
@duvivier duvivier requested a review from apcraig November 3, 2018 04:56
@apcraig apcraig merged commit 436035b into CICE-Consortium:master Nov 3, 2018
@duvivier duvivier mentioned this pull request Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants